Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dynamo sandbox app.config #14713

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

mjkkirschner
Copy link
Member

Purpose

This config was out of date by many years and caused exceptions to be thrown at startup.
Also remove a path to a missing resource.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

github-actions bot commented Dec 7, 2023

⚠️ [run-bin-diff-net60-windows] - Files Added/Deleted::1 file(s) have been deleted!

Copy link

github-actions bot commented Dec 7, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

Copy link

github-actions bot commented Dec 7, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@QilongTang QilongTang added this to the 3.0 milestone Dec 8, 2023
@mjkkirschner mjkkirschner merged commit 0947455 into DynamoDS:master Dec 8, 2023
22 checks passed
@mjkkirschner mjkkirschner deleted the sandboxconfig branch December 8, 2023 14:39
saintentropy pushed a commit to saintentropy/Dynamo that referenced this pull request Dec 9, 2023
* remove config

* remove autogen stuff

(cherry picked from commit 0947455)
QilongTang pushed a commit that referenced this pull request Dec 11, 2023
* remove duplicate dyf file warning from preview generation process (#14711)

- dynamo would issue a warning and fail to publish a package if an 'unqualified' file is being used, such as a dyf file already under package control
- this check is done when publishing package locally, but I have incorrectly added it to the process of creating a build preview, which stops the process for both local and online submit workflow

(cherry picked from commit 3ea1c5c)

* update (#14710)

Co-authored-by: pinzart <[email protected]>
(cherry picked from commit d5e6c9b)

* remove package version limitation (#14716)

- now allows package version to start with 0
- cannot have 0.0.0 package version

(cherry picked from commit 992e54c)

* Localize menu items is Graphic Element Scale dropdown (#14714)

* Fix PostDiff job

* fix

(cherry picked from commit 006113e)

* remove dynamo sandbox app.config (#14713)

* remove config

* remove autogen stuff

(cherry picked from commit 0947455)

* DYN-6527: Fix graph update for primitive input nodes that are first initialized to null  (#14703)

* remove coreclr-ncalc references

* add failing test for dropdown node

* cleanup

* update tests

* attempt initial fix

* cleanup

* update test

* review comments

* add code comments

(cherry picked from commit 8987869)

---------

Co-authored-by: Deyan Nenov <[email protected]>
Co-authored-by: pinzart90 <[email protected]>
Co-authored-by: Ashish Aggarwal <[email protected]>
Co-authored-by: Michael Kirschner <[email protected]>
Co-authored-by: aparajit-pratap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants